Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix redis session failed #3086

Merged
merged 2 commits into from
Dec 4, 2017
Merged

Fix redis session failed #3086

merged 2 commits into from
Dec 4, 2017

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 4, 2017

This will fix #3085.

@lunny lunny added this to the 1.4.0 milestone Dec 4, 2017
@codecov-io
Copy link

codecov-io commented Dec 4, 2017 •
edited
Loading

Codecov Report

Merging #3086 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3086      +/-   ##
==========================================
+ Coverage   33.29%   33.31%   +0.01%     
==========================================
  Files         273      273              
  Lines       39954    39954              
==========================================
+ Hits        13304    13309       +5     
+ Misses      24749    24745       -4     
+ Partials     1901     1900       -1
Impacted Files Coverage Δ
modules/setting/setting.go 46.93% <100%> (ø) ⬆️
models/repo_indexer.go 52.97% <0%> (+0.99%) ⬆️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0332b8f...7a1c3ee. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 4, 2017
@lafriks
Copy link
Member

lafriks commented Dec 4, 2017

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 4, 2017
@Bwko
Copy link
Member

Bwko commented Dec 4, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 4, 2017
@lunny lunny merged commit 2738eff into go-gitea:master Dec 4, 2017
@lunny lunny deleted the lunny/fix_redis_cache branch December 4, 2017 15:00
lunny added a commit to lunny/gitea that referenced this pull request Dec 4, 2017
@lunny
fix redis cache failed (go-gitea#3086)
3c4e26e
@lunny lunny mentioned this pull request Dec 4, 2017
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Dec 4, 2017
lafriks pushed a commit that referenced this pull request Dec 4, 2017
@lunny @lafriks
fix redis cache failed (#3086) (#3089)
b9abcb3
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Redis session broken after upgrade to 1.3.0
5 participants
@lunny @codecov-io @lafriks @Bwko @tboerger